fix(ui): swap transposed table and compact view icons - #722
Closed
hamsa0x7 wants to merge 1 commit into
Closed
Conversation
4 tasks
Collaborator
|
Hey @hamsa0x7, You're right, and so is the reasoning in #701 — the compact view is a grid of tiles and the table view is full-width rows, so the icons were the wrong way round. I've cherry-picked this onto Closing this as the commit has landed. Thanks! This will be available for testing in Release 28. Drafted and approved by @memstechtips - Sent by Memory's Agent |
memory-agent
added
the
done - awaiting new release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Swaps the icons for Table View and Compact View in the Software & Apps page to correct their visual representation.
Problem
The Table View and Compact View icons were transposed. The Table View (displaying full-width rows) used the grid-like
TableSimpleicon, while the Compact View (displaying a wrapping grid of cells) used the list-likeLineHorizontal3icon.Changes
src/Winhance.UI/Features/SoftwareApps/SoftwareAppsPage.xaml: Swapped theIconproperties of theTableViewToggle(TableSimple->LineHorizontal3) andCompactViewToggle(LineHorizontal3->TableSimple) toggle buttons.Related Issues
Fixes #701